Skip to content

fix unnecessary_semicolon: FN on #[feature(stmt_expr_attributes)] #15481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix unnecessary_semicolon: FN on #[feature(stmt_expr_attributes)] #15481

wants to merge 1 commit into from

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Aug 13, 2025 •
edited by rustbot
Loading

inspired by #15476

changelog: [unnecessary_semicolon]: FN on #[feature(stmt_expr_attributes)]

Summary Notes

Managed by @rustbot—see help for details

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 13, 2025
@ada4a ada4a force-pushed the unnecessary-semicolon-with-attrs branch from 1e0155e to a8320b3 Compare August 22, 2025 13:34
@ada4a ada4a closed this Aug 22, 2025
@ada4a ada4a deleted the unnecessary-semicolon-with-attrs branch August 22, 2025 13:38
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 22, 2025
@blyxyas
Copy link
Member

blyxyas commented Aug 22, 2025

@ada4a is there a reason why you closed this, or are you just over-capacity and this one wasn't that high up in the list of priorities? =^w^=

@ada4a ada4a restored the unnecessary-semicolon-with-attrs branch August 22, 2025 16:35
@ada4a
Copy link
Contributor Author

ada4a commented Aug 22, 2025

Oops, thanks for letting me know -- I just messed up this particular branch when rebasing all the bajillion of them that I have onto the latest master (for the rust sync). Reopened it^^

@ada4a ada4a reopened this Aug 22, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 22, 2025
@ada4a ada4a force-pushed the unnecessary-semicolon-with-attrs branch from a8320b3 to 2aff1b7 Compare August 22, 2025 16:39
@ada4a
Copy link
Contributor Author

ada4a commented Aug 22, 2025 •
edited
Loading

Oh, and I just noticed that I've been spamming @profetia everytime I rebased, because my commit included a link to one of her PRs. Sorry @profetia, I removed the link now^^

But isn't rustbot supposed to complain in such cases?.. I'm pretty sure I've seen such warnings in the past

@blyxyas
Copy link
Member

blyxyas commented Aug 22, 2025

Hmmm weird, the [issue-links] table is defined in our triagebot.toml, so it's supposed to warn about that. Weird.

blyxyas
blyxyas approved these changes Aug 24, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️
I'll mark this as blocked to be reviewed after the feature freeze, because it still creates a new environment for things to fail, but thanks a lot for the fix. When the feature freeze is over, I'll merge it.

@rustbot blocked
@rustbot note Feature freeze
@rustbot label +C-enhancement

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ada4a @rustbot @blyxyas